Register missing fixers in default set, enforce CS in CI, fix README#82
Merged
Conversation
Member
Author
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Three fixes found while reviewing the repo:
1. Register two documented-but-unshipped fixers
StandaloneLineInMultilineArrayFixerandStandaloneLineConstructorParamFixerare documented in the README and fully tested, but were missing fromconfig/symplify.php— so they never ran for users ofSetList::SYMPLIFY. Now registered.2. CI was not enforcing coding standard
The
Coding Standardjob rancomposer fix-cs(ecs --fix), which auto-corrects and exits 0 — style regressions could never fail the build. Switched tocomposer check-cs. For a coding-standard package this is the most important check to actually enforce.3. CI hardening
testsjob with a PHP matrix (8.2,8.3,8.4) — previously tests only ran on 8.2, despite>=8.2support and version-conditional code paths.actions/checkout@v3 → v4andramsey/composer-install@v2 → v3.4. README accuracy
12 Rules → 14 Rules(all 14 fixers are documented).RemoveRedundantDescriptionFixer(does not exist) →RemoveMethodNameDuplicateDescriptionFixer.Verification
Local run all green: PHPStan (lvl 8), ECS, Rector, PHPUnit (150 tests).